Skip to content

Make SelectExpandBinder public and register it in RequestContainer (the same way as FilterBinder) #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
savelievser opened this issue Sep 14, 2019 · 3 comments
Open

Make SelectExpandBinder public and register it in RequestContainer (the same way as FilterBinder) #1900

savelievser opened this issue Sep 14, 2019 · 3 comments
Labels
feature

Comments

@savelievser
Copy link

FilterBinder is a good example of class that is open for expanding. I can derive from it and override some methods. Then I can register my class in container, so i will be used instead of original FilterBinder. But I can't do the same with SelectExpandBinder. I would be great to refactor it in the same way and make public.
@xuzhg
Copy link
Member

xuzhg commented Sep 19, 2019

@savelievser Would you please contribute it? we'd happy to review and merge it.

@xuzhg xuzhg added the feature label Sep 19, 2019
@savelievser
Copy link
Author

@xuzhg sure

savelievser pushed a commit to savelievser/WebApi that referenced this issue Sep 29, 2019
Make SelectExpandBinder public and provide possibility to override it…
e0172ad 
…s functionality (OData#1900)
savelievser pushed a commit to savelievser/WebApi that referenced this issue Sep 29, 2019
Make AggregationBinder public and provide possibility to override its…
0e24194 
… functionality (OData#1900)
@savelievser savelievser mentioned this issue Sep 29, 2019
Closed
2 tasks
savelievser added a commit to savelievser/WebApi that referenced this issue Oct 3, 2019
@savelievser
Make SelectExpandBinder public and provide possibility to override it…
7192097 
…s functionality (OData#1900)
savelievser added a commit to savelievser/WebApi that referenced this issue Oct 3, 2019
@savelievser
Make AggregationBinder public and provide possibility to override its…
02241a4 
… functionality (OData#1900)
@savelievser savelievser mentioned this issue Oct 3, 2019
Open
1 task
@dropsonic
Copy link

@xuzhg any updates on this feature and the corresponding PR? It's been a year since the PR was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dropsonic @savelievser @xuzhg