Skip to content

Dataset set postmatch 5576 v4 #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Collaborator

Ticket

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/5576

#2000 with more tests for complex cases

Do I get right the expected behavior of datasets-multibuf-postmatch ?
Rule alert http any any -> any any (msg:"HTTP learning"; http.request_header; content:"toto"; dataset:set,http_match,type string,save http_match.csv; sid:1;)
will save in dataset only the headers having the content toto and (not the user agent curl for instance)

@catenacyber catenacyber added the requires suricata pr Depends on a PR in Suricata label Oct 15, 2024
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from 9e66688 to c004733 Compare October 15, 2024 12:41
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from c004733 to 61a9767 Compare October 15, 2024 14:08
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from 61a9767 to 2fdca6f Compare October 15, 2024 19:51
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from 2fdca6f to e842b6a Compare October 29, 2024 10:36
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from e842b6a to 3936e33 Compare November 18, 2024 13:41
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from 3936e33 to a502637 Compare December 2, 2024 09:43
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from a502637 to 3f7329a Compare December 5, 2024 12:33
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from 3f7329a to cceb634 Compare February 19, 2025 12:44
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch 3 times, most recently from 8477867 to a0504cf Compare April 6, 2025 16:42
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from a0504cf to 3d2f8d8 Compare May 16, 2025 14:06
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from 3d2f8d8 to 67362a9 Compare May 20, 2025 07:26
@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from 67362a9 to ee179ae Compare May 27, 2025 14:18
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good to me :)

nit: 08f412d

has a typo:
:s/retreieves/retrieves

@catenacyber catenacyber force-pushed the dataset-set-postmatch-5576-v4 branch from 8d1dc24 to 26d742a Compare June 11, 2025 18:56
@catenacyber
Copy link
Collaborator Author

nit: 08f412d

has a typo: :s/retreieves/retrieves

Thanks, fixed

Andreas Herz and others added 4 commits June 18, 2025 14:19
Ticket: 5576

Signature full match does not happen on first packet inspected,
but signature gets stored as partially matching so far,
and then postmatch retrieves the buffer to set in the dataset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires suricata pr Depends on a PR in Suricata
Development

Successfully merging this pull request may close these issues.

2 participants