-
Notifications
You must be signed in to change notification settings - Fork 100
Dataset set postmatch 5576 v4 #2093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
catenacyber
wants to merge
4
commits into
OISF:master
Choose a base branch
from
catenacyber:dataset-set-postmatch-5576-v4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dataset set postmatch 5576 v4 #2093
catenacyber
wants to merge
4
commits into
OISF:master
from
catenacyber:dataset-set-postmatch-5576-v4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e66688
to
c004733
Compare
c004733
to
61a9767
Compare
61a9767
to
2fdca6f
Compare
2fdca6f
to
e842b6a
Compare
This was referenced Oct 29, 2024
e842b6a
to
3936e33
Compare
3936e33
to
a502637
Compare
This was referenced Dec 2, 2024
a502637
to
3f7329a
Compare
3f7329a
to
cceb634
Compare
Closed
8477867
to
a0504cf
Compare
a0504cf
to
3d2f8d8
Compare
3d2f8d8
to
67362a9
Compare
67362a9
to
ee179ae
Compare
ee179ae
to
b9bc201
Compare
b9bc201
to
8d1dc24
Compare
jufajardini
reviewed
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8d1dc24
to
26d742a
Compare
Thanks, fixed |
26d742a
to
dbc1af3
Compare
This was referenced Jun 14, 2025
Ticket: 5576
Ticket: 5576 Signature full match does not happen on first packet inspected, but signature gets stored as partially matching so far, and then postmatch retrieves the buffer to set in the dataset.
dbc1af3
to
160dcde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/5576
#2000 with more tests for complex cases
Do I get right the expected behavior of datasets-multibuf-postmatch ?
Rule
alert http any any -> any any (msg:"HTTP learning"; http.request_header; content:"toto"; dataset:set,http_match,type string,save http_match.csv; sid:1;)
will save in dataset only the headers having the content
toto
and (not the user agent curl for instance)