tests: check for more ruletypes in firewall mode - v4#3032
Closed
jufajardini wants to merge 3 commits intoOISF:masterfrom
Closed
tests: check for more ruletypes in firewall mode - v4#3032jufajardini wants to merge 3 commits intoOISF:masterfrom
jufajardini wants to merge 3 commits intoOISF:masterfrom
Conversation
Add suricata-verify tests for keywords that emit 'has not been tes for firewall rules' warnings. Tests are consolidated into 3 test cases. - firewall-keyword-icode: tests icode with ICMP echo traffic - firewall-keyword-http: tests pcre, urilen, dataset with HTTP traff - firewall-keyword-tls: tests tls.cert_chain_len with TLS cert chain These tests validate that the keywords function correctly in firewal mode and can be used to justify adding SIGMATCH_SUPPORT_FIREWALL to each keyword in the engine. Related to Ticket #8387
Based on initial work by Yash Datre - dns.opcode - dns.query with datarep Related to Ticket #8387
Related to Ticket #8387
This was referenced Apr 17, 2026
| accept:hook udp:all any any -> any any (sid:100;) | ||
|
|
||
| # Test dns.opcode: match standard query (opcode 0) and alert | ||
| accept:hook dns:request_complete any any -> any any (dns.opcode:0; alert; sid:1;) |
Member
There was a problem hiding this comment.
this ruleset exposes a bug: the absence of a dns:request_started rule should have lead to a default drop, but didn't.
Collaborator
|
Seems replaced by #3039 right ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #3025
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8387