Skip to content

http2: do not log empty objects for request or response #13598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7741

Describe changes:

  • http2: do not log empty objects for request or response

@jasonish should we enforce minProperties for every object in our json schema ?

@catenacyber catenacyber requested a review from a team as a code owner July 15, 2025 13:00
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (07b7f36) to head (0ed7f94).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13598      +/-   ##
==========================================
+ Coverage   83.63%   83.68%   +0.04%     
==========================================
  Files        1011     1011              
  Lines      275071   275077       +6     
==========================================
+ Hits       230050   230189     +139     
+ Misses      45021    44888     -133     
Flag Coverage Δ
fuzzcorpus 62.77% <100.00%> (+0.11%) ⬆️
livemode 19.03% <0.00%> (+0.02%) ⬆️
pcap 44.70% <100.00%> (-0.02%) ⬇️
suricata-verify 65.06% <100.00%> (-0.01%) ⬇️
unittests 59.18% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 26898

@jasonish
Copy link
Member

@jasonish should we enforce minProperties for every object in our json schema ?

Probably a good practice to start adding, but I wouldn't jump to adding it to all items. Maybe when 9.0 opens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants