-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Bindgen more 7667 v13.2.2 #13599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
catenacyber
wants to merge
13
commits into
OISF:master
Choose a base branch
from
catenacyber:bindgen-more-7667-v13.2.2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bindgen more 7667 v13.2.2 #13599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7667
Ticket: 7667
Ticket: 7667
With just local exceptions
Ticket: 7667
Ticket: 7667 just use it directly, with bindgen, and cfg not test
Ticket: 7667 just use it directly, with bindgen, and cfg not test
Ticket: 7667
Ticket: 7667
Ticket: 7667
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13599 +/- ##
==========================================
- Coverage 83.69% 83.68% -0.02%
==========================================
Files 1011 1009 -2
Lines 275071 275087 +16
==========================================
- Hits 230210 230194 -16
- Misses 44861 44893 +32
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Information: QA ran without warnings. Pipeline = 26909 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7667
Describe changes:
#13563 without bad commit that will get its own independent PR
Jason could you review the commits one by one until you find a commit that you do not approve ?