Skip to content

Amend build flags to install pip for python v2.7 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

ajorpheus
Copy link
Contributor

No description provided.

@ajorpheus
Copy link
Contributor Author

This depends on #16 which should be reviewed and merged first.

@ajorpheus ajorpheus force-pushed the fix/python2-install-pip branch from 40f0ae9 to 7842e67 Compare February 13, 2019 11:02
@ajorpheus
Copy link
Contributor Author

This depends on #16 which should be reviewed and merged first.

This has been merged.

@ajorpheus
Copy link
Contributor Author

The Travis Build are failing due to the --enable-optimizations flag for python builds which triggers Profile Guided Optimizations (PGO) requiring the execution of all tests to generate profile data which is then used to optimize the compiled code (this results in a faster python executable being generated). However, the side effect of this is that the builds take much longer and hit the timeout limit that Travis CI has for a job.

For the change in build times look at this comment (and the conversation thread itself) : docker-library/python#160 (comment)

Travis CI build timeouts are documented here: https://docs.travis-ci.com/user/customizing-the-build/#build-timeouts

Given the above, I am going to merge this in.

@ajorpheus ajorpheus merged commit f8ae06b into master Feb 13, 2019
@ajorpheus ajorpheus deleted the fix/python2-install-pip branch February 13, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants