Skip to content

Conversation

@romanett
Copy link
Contributor

@romanett romanett commented May 2, 2025

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@romanett romanett requested a review from mrsuciu May 2, 2025 14:45
@romanett romanett added this to the 1.5.376 Maintenance Update milestone May 2, 2025
@romanett romanett self-assigned this May 2, 2025
@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.98%. Comparing base (d5fd96b) to head (4b7adee).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...braries/Opc.Ua.Server/NodeManager/SamplingGroup.cs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3070      +/-   ##
==========================================
- Coverage   57.02%   56.98%   -0.04%     
==========================================
  Files         357      357              
  Lines       68951    68981      +30     
  Branches    14156    14161       +5     
==========================================
- Hits        39317    39312       -5     
- Misses      25395    25424      +29     
- Partials     4239     4245       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrsuciu mrsuciu merged commit 7d3f545 into OPCFoundation:master May 23, 2025
75 of 77 checks passed
@romanett romanett deleted the fixSamplingGroup branch May 23, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SamplingGroup throws ObjectDisposedException if all MonitoredItems are removed from a Subscription

2 participants