-
Notifications
You must be signed in to change notification settings - Fork 99
Generate EncodingMask encoding and decoding according to the current SDK release #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate EncodingMask encoding and decoding according to the current SDK release #212
Conversation
|
|
|
Update ModelCompiler to use SDK 1.05.376. Please verify. |
|
It still generates invalid code in case of a complex data type with optional fields deriving from a data type without optional fields. I think the current solution where the |
5f2c2b9 to
b163042
Compare
|
The uint was used because casting was going to be needed if there was a subtype because the subtype declares a new enum with new fields. The requirement to allow subtypes of StructureType=StructrureWithOptional field with the base type of StructureType=Structrure has been approved by the WG. It has not been implemented yet. |
|
That issue should be addressed by the proposed change, since every generated subtype introduces its own With the hooks |
c3e90d9 to
80d533f
Compare
Removed currently unsupported EncodingMask calls.
This allows for a simpler and more failsafe usage.
88f4c16 to
7f09eee
Compare
…current SDK release (#212)" Does not work, breaks many things.
This fixes Issues #211 and #202
The dervied class with optional field(s) is now able to directly influence the creation of the encoding mask and it is guaranteed to happen at the beginning of the encoding and decoding.
Removed the invalid JSON encoding compatible methods for reading and writing an encoding mask since they were not correctly generated.