Skip to content

fix: Remove duplicated attribute and fix organization name #6840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amontenegro merged 1 commit into from
Jul 31, 2023
+0 −17
Merged

fix: Remove duplicated attribute and fix organization name #6840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions orcid-core/src/main/java/org/orcid/pojo/summary/AffiliationSummary.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ public class AffiliationSummary {
public String startDate;
public String endDate;
public String role;
public String title;
public String type;
public boolean validatedOrSelfAsserted;

Expand Down Expand Up @@ -56,14 +55,6 @@ public void setRole(String role) {
this.role = role;
}

public String getTitle() {
return title;
}

public void setTitle(String title) {
this.title = title;
}

public String getType() {
return type;
}
Expand Down Expand Up @@ -114,14 +105,6 @@ public static AffiliationSummary valueOf(org.orcid.jaxb.model.v3.release.record.
form.setRole(as.getRoleTitle());
}

if (!PojoUtil.isEmpty(as.getDepartmentName())) {
form.setOrganizationName(as.getDepartmentName());
}

if (!PojoUtil.isEmpty(as.getRoleTitle())) {
form.setRole(as.getRoleTitle());
}

form.setType(type);

if (as.getSource() != null) {
Expand Down