Skip to content

Remove tokens from cache #6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cryptalith merged 2 commits into from
Aug 23, 2023
+10 −0
Merged

Remove tokens from cache #6877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2448a5e
Remove tokens from cache
amontenegro Aug 23, 2023
0244bff
Merge branch 'main' into RemoveTokensFromCacheOnRevoke
cryptalith Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions orcid-core/src/main/java/org/orcid/core/oauth/service/OrcidOauth2TokenDetailServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,16 @@ public void disableAccessTokenByUserOrcid(String userOrcid, RevokeReason reason)
@Override
@Transactional
public void disableClientAccess(String clientDetailsId, String userOrcid) {
// As a security measure, remove any user tokens from the cache
List<OrcidOauth2TokenDetail> userTokens = findByUserName(userOrcid);
if(userTokens != null && !userTokens.isEmpty()) {
for(OrcidOauth2TokenDetail token : userTokens) {
if(clientDetailsId.equals(token.getClientDetailsId())) {
redisClient.remove(token.getTokenValue());
}
}
}
// And then disable all user tokens
orcidOauth2TokenDetailDao.disableClientAccessTokensByUserOrcid(userOrcid, clientDetailsId);
}

Expand Down