fix: make StringValue public and inherit Value

[berezovskyi]

Closes #396

Summary by CodeRabbit

• Refactor

  • StringValue interface is now publicly accessible and inherits from the Value interface

• Bug Fixes

  • Corrected API documentation references in StringValue interface

[coderabbitai]

Walkthrough

The StringValue interface visibility is changed from internal (implicit default) to public and is now declared to extend the Value interface. Additionally, a documentation typo is corrected from "olsc.where" to "oslc.where", improving external API accessibility and code clarity.

Changes

Cohort / File(s)	Summary
Interface Visibility and Inheritance Change OSLC4Net_SDK/OSLC4Net.Core.Query/StringValue.cs	Changed StringValue from internal to public interface StringValue : Value; corrected XML documentation typo from "olsc.where" to "oslc.where"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

The change is straightforward: a single-file visibility modification adding public access and interface inheritance to StringValue. The scope is minimal with no complex logic or dependencies to analyze, though reviewers should verify the interface inheritance relationship aligns with the intended API design.

Poem

A rabbit hops with glee so bright, 🐰
StringValue now shines in public light!
No longer hidden, but free to share,
Extending Value with utmost care.
Documentation fixed with pride—
Our SDK can open wide! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "fix: make StringValue public and inherit Value" directly and clearly summarizes the main changes in the changeset. It is specific, concise, and accurately reflects the two primary modifications: changing StringValue from internal to public visibility and adding inheritance from the Value interface. The title uses clear, action-oriented language and would be easily understood by teammates reviewing the commit history.
Linked Issues Check	✅ Passed	The PR directly addresses the primary objective from linked issue #396, which asks why the StringValue interface is not public. The changes implement this requirement by changing StringValue from internal to public visibility. Additionally, the PR makes StringValue inherit from Value, which appears to be a related fix included as part of resolving the underlying issue. Both the main objective (making StringValue public) and the supporting change (inheritance from Value) align with addressing the concern raised in the linked issue.
Out of Scope Changes Check	✅ Passed	The code changes are scoped to the primary objective of making StringValue public and having it inherit Value, which directly addresses issue #396. The raw_summary also indicates a minor documentation correction to the XML summary comment (from "olsc.where" to "oslc.where"), which is a related fix within the same file. No unrelated or extraneous changes are evident; all modifications are focused on resolving the linked issue.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch b-stringvalue-publicc

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.55%. Comparing base (ec946b7) to head (e1f44f8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         166      166           
  Lines       15388    15388           
  Branches     1024     1024           
=======================================
  Hits         7626     7626           
  Misses       7479     7479           
  Partials      283      283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

OSLC4Net_SDK/OSLC4Net.Core.Query/StringValue.cs (1)

19-20: Doc fix LGTM.

“oslc.where” is correct and improves clarity. Consider linking to the OSLC Query “where” grammar in remarks for discoverability.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec946b7 and e1f44f8.

📒 Files selected for processing (1)

• OSLC4Net_SDK/OSLC4Net.Core.Query/StringValue.cs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.cs

⚙️ CodeRabbit configuration file

**/*.cs: Review the C# code against the Microsoft Framework design guidelines as well as 10 guidelines
from "Building Maintainable Software" by Joost Visser. Point out deviations and improvements.

Files:

• OSLC4Net_SDK/OSLC4Net.Core.Query/StringValue.cs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

• GitHub Check: test (windows-latest, 10.x, net10.0)
• GitHub Check: test (windows-latest, 9.x, net9.0)
• GitHub Check: test (ubuntu-24.04, 10.x, net10.0)
• GitHub Check: test (ubuntu-24.04-arm, 8.x, net8.0)
• GitHub Check: test (windows-latest, 8.x, net8.0)
• GitHub Check: test (ubuntu-24.04-arm, 10.x, net10.0)
• GitHub Check: test (ubuntu-24.04-arm, 9.x, net9.0)
• GitHub Check: test (ubuntu-24.04, 8.x, net8.0)
• GitHub Check: test (ubuntu-24.04, 9.x, net9.0)
• GitHub Check: Analyze (csharp)

🔇 Additional comments (1)

OSLC4Net_SDK/OSLC4Net.Core.Query/StringValue.cs (1)

21-24: All critical concerns verified and resolved.

The code passes all verification checks:

1. Accessibility (CS0060): ✅ Value interface is public
2. Member compatibility: ✅ Value interface has only ValueType Type { get; } property—no conflicts with StringValue's string Value { get; }
3. XML documentation: ✅ StringValue interface already includes XML doc comment (lines 18-20)

StringValue is correctly defined as a public interface inheriting from Value with proper accessibility. The naming deviation from .NET guidelines (I-prefix convention) is already acknowledged in the review comment as a compatibility decision.