Repository navigation
MASTG-TEST-0212: Clarify test case for hardcoded cryptographic keys - #3945
Open
cpholguera wants to merge 3 commits into
Open
cpholguera wants to merge 3 commits into
cpholguera wants to merge 3 commits into
Conversation
Updated the test case to clarify the focus on hardcoded cryptographic keys and the importance of tracing key material sources. Enhanced steps and observations for better guidance on identifying hardcoded keys.
cpholguera
commented
Sep 1, 2026
cpholguera
commented
Sep 1, 2026
Collaborator
|
Should we also mention non OS crypto? If the app provides its own crypto library (for example in Android native), the test should also make sure to detect hardcoded material there. If we add that, we should align the iOS test MASTG-TEST-0213. @cpholguera You can add me to review it and if I would make the PR for the iOS test, if you agree to add non OS-APIs. |
Collaborator
Author
|
Thanks @bernhste! The review is assigned to you. Please consider whether we should add that to this test or it'd be better to have as a separate / independent test. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the test case to clarify the focus on hardcoded cryptographic keys and the importance of tracing key material sources. Enhanced steps and observations for better guidance on identifying hardcoded keys.