Repository navigation
Update iOS and Android platform interaction for App Notifications - #3985
mateofumis wants to merge 6 commits into
Conversation
|
@cpholguera I think we can link the iOS KNOW file into the MASWE-0037 as I commented in the #1163 so both Android and iOS are mentioned. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the unresolved iOS authorization and local-notification coverage gaps, along with heading and wording updates.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates OWASP MASTG notification guidance for iOS and Android.
Changes:
- Adds iOS notification behavior and privacy controls.
- Rewrites and relocates Android notification guidance.
- Documents permissions, visibility controls, listener access, and OTP redaction.
| File | Reviewed change |
|---|---|
knowledge/ios/MASVS-PLATFORM/MASTG-KNOW-0x01.md |
Adds iOS notification concepts and privacy controls. |
knowledge/android/MASVS-STORAGE/MASTG-KNOW-0054.md |
Removes the former Android article location. |
knowledge/android/MASVS-PLATFORM/MASTG-KNOW-0054.md |
Adds the revised Android notification documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
I agree with Copilot's suggestion regarding the phrasing in the sentence "privacy implications that can be noted", so I'm applying that change. Regarding the suggested The mention of "local and remote app notifications" in the iOS KNOW is only intended as introductory context. The scope of this PR comes from #1163, which focuses on limiting the information exposed through notifications when they have a high confidentiality. Authorization and additional details about local notifications are in fact valid topics, but I would prefer to include them only if they directly contribute to understanding notification content exposure and privacy behavior or implications. I believe otherwise, expanding into those topics may move the KNOW away from the original scope of the issue. My guess is that Copilot may see these as gaps because the Android KNOW mentions related topics such as notification permissions and listener access, but that doesn't necessarily mean equivalent coverage is needed on iOS. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
TheDauntless
left a comment
There was a problem hiding this comment.
Some small comments, but generally looks good!
…n-on-notifications
…interaction-on-notifications' into update/ios-and-android-platform-interaction-on-notifications

This PR closes #1163
Description
This PR adds a new MASTG-KNOW for iOS covering App Notifications, and updates the current
MASTG-KNOW-0054.For the
MASTG-KNOW-0054, this ended up being a larger rewrite rather than a small update because the current content predates the current MASTG Knowledge authoring guidelines and contains some platform behavior that is no longer fully accurate.The main changes are:
MASVS-STORAGEtoMASVS-PLATFORMto align it withMASWE-0037andMASTG-TEST-0315, which covers sensitive data exposed via Android notifications.NotificationListenerServiceand process or retain it according to their own implementation.NotificationListenerServicedescription to clarify that notification events are delivered through system callbacks after the user grants notification access.VISIBILITY_PUBLIC,VISIBILITY_PRIVATE,VISIBILITY_SECRET, andsetPublicVersion.POST_NOTIFICATIONSruntime permission introduced in Android 13 (API level 33).NotificationListenerServicefrom reading unredacted notification content when an OTP is detected.Regarding WAMR: I think it's a useful real-world example of what access to notification content enables to an attacker, but I intentionally left it out of the KNOW because I think it fits better for a demo.
AI Tool Disclosure
Check exactly one option.
Contributor Checklist