Deneb E2E #13040
Merged
Deneb E2E #13040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go.mod
Outdated
| @@ -267,3 +267,5 @@ replace github.com/json-iterator/go => github.com/prestonvanloon/go v1.1.7-0.201 | |||
|
|
|||
| // See https://github.com/prysmaticlabs/grpc-gateway/issues/2 | |||
| replace github.com/grpc-ecosystem/grpc-gateway/v2 => github.com/prysmaticlabs/grpc-gateway/v2 v2.3.1-0.20230315201114-09284ba20446 | |||
|
|
|||
| replace github.com/ethereum/go-ethereum => github.com/lightclient/go-ethereum v1.10.10-0.20230829211949-79f3c2d9c96b | |||
There was a problem hiding this comment.
Can you update to master?
rkapka
reviewed
Oct 31, 2023
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
james-prysm
reviewed
Nov 1, 2023
| @@ -28,6 +28,6 @@ const ( | |||
| MaxWithdrawalsPerPayload = 4 // MaxWithdrawalsPerPayloadLength defines the maximum number of withdrawals that can be included in a payload. | |||
| MaxBlobsPerBlock = 6 // MaxBlobsPerBlock defines the maximum number of blobs with respect to consensus rule can be included in a block. | |||
| MaxBlobCommitmentsPerBlock = 16 // MaxBlobCommitmentsPerBlock defines the theoretical limit of blobs can be included in a block. | |||
| BlobLength = 4 // BlobLength defines the byte length of a blob. | |||
| BlobSize = 128 // defined to match blob.size in bazel ssz codegen | |||
| BlobLength = 131072 // BlobLength defines the byte length of a blob. | |||
There was a problem hiding this comment.
both of blob length and blobsize are the same number?
There was a problem hiding this comment.
Yeap, they mean the same thing afaik
james-prysm
reviewed
Nov 1, 2023
| sender := common.HexToAddress(addr) | ||
| chainid, err := backend.ChainID(context.Background()) | ||
| nonce, err := backend.PendingNonceAt(context.Background(), fundedAccount.Address) |
There was a problem hiding this comment.
why did this change from sender to fundedAccount?
There was a problem hiding this comment.
Blob transactions and normal transactions can't come from the same address as geth would fail then
james-prysm
reviewed
Nov 1, 2023
| switch epoch { | ||
| case 11: | ||
| lastForkEpoch := forks.LastForkEpoch() | ||
| freezeStartEpoch := lastForkEpoch + 1 |
There was a problem hiding this comment.
nice improvement naming these
terencechain
approved these changes
Nov 8, 2023
prestonvanloon
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds deneb support to our E2E tests. This adds the ability to generate blob transactions and have them broadcasted to the network so that we can test the happy /unhappy paths for prysm in deneb. Due to external dependencies currently, deneb has been disabled for tests which use multiclient and web3signer. Once we have this fixed upstream we can start running E2E tests till Deneb for those particular tests.
Which issues(s) does this PR fix?
N.A
Other notes for review