Add install prefix and hostname to CUDA setup script#401
Merged
Conversation
Align setup-cuda.sh with setup-rocm.sh by adding HOSTN variable, including hostname in the build directory name, and setting CMAKE_INSTALL_PREFIX so `make install` targets a local directory instead of defaulting to /usr/local.
ggeorgakoudis
approved these changes
Feb 10, 2026
Collaborator
ggeorgakoudis
left a comment
ggeorgakoudis
left a comment
There was a problem hiding this comment.
LGTM
Include also LLVM version information (in ROCm it is implied), e.g.
build-${HOSTN}-cuda-${CUDA_VERSION}-llvm-${LLVM_VERSION}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align
setup-cuda.shwithsetup-rocm.shconventions.HOSTNvariable to strip digits from hostnamebuild-${HOSTN}-cuda-${CUDA_VERSION})CMAKE_INSTALL_PREFIXto../install-${HOSTN}-cuda-${CUDA_VERSION}somake installtargets a local directory instead of defaulting to/usr/local