Skip to content
This repository was archived by the owner on Feb 13, 2019. It is now read-only.

Removed .remote(), added mocha test coverage for all application types etc. #59

Merged
merged 2 commits into from
Feb 7, 2015

Conversation

spboyer
Copy link
Contributor

@spboyer spboyer commented Feb 5, 2015

Removed .remote(),
added mocha test coverage for all application types and sub generators.
Added scripts section to package.json for Travis CI support.

You can run test by executing npm test be sure to first do npm install to restore any dependencies and npm link to run locally.

@sayedihashimi
@peterblazejewicz

Shayne Boyer added 2 commits February 5, 2015 14:58
…s and sub generators. Added scripts section and npm test for Travis CI support.
@peterblazejewicz
Copy link
Member

@spboyer
I've got all tests passing locally:

[...]
      ✓ mvcTest/Views/Shared/_Layout.cshtml created. 


  49 passing (502ms)

Will let you know about created content asap.

@peterblazejewicz
Copy link
Member

@spboyer I won't be able to verify if content is runnable on OS X - but that is rather @aspnet/Home problem.
x-ref: dotnet/aspnetcore#310

@sayedihashimi
Copy link
Member

Sorry for the delay I'm just getting to this. I will try it out and report back. I noticed that the Travis CI build failed with the error below.

1) aspnet - Empty Application "before all" hook:

Uncaught TypeError: First argument needs to be a number, array or string.

at new Buffer (buffer.js:188:15)

at EditionInterface.module.exports [as read] (/home/travis/build/OmniSharp/generator-aspnet/node_modules/yeoman-generator/node_modules/mem-fs-editor/actions/read.js:9:36)

at template (/home/travis/build/OmniSharp/generator-aspnet/node_modules/yeoman-generator/lib/actions/actions.js:191:34)

at yeoman.generators.Base.extend.writing (/home/travis/build/OmniSharp/generator-aspnet/app/index.js:103:18)

at /home/travis/build/OmniSharp/generator-aspnet/node_modules/yeoman-generator/lib/base.js:408:16

at processImmediate [as _immediateCallback] (timers.js:354:15)

npm ERR! Test failed. See above for more details.

npm ERR! not ok code 0

The command "npm test" exited with 1.

@sayedihashimi sayedihashimi merged commit 52d67ce into master Feb 7, 2015
@sayedihashimi
Copy link
Member

The changes are really amazing, thanks a lot for putting this together. Now the new project experience is really fast and works on an airplane :) People are really gonna like this improvement.

OK the test cases were passing locally and I tried out the changes and things look to work so I merged it. Let's see if it passes from the master branch.

@spboyer @peterblazejewicz Should we go ahead and release it?

@sayedihashimi
Copy link
Member

FYI I have updated the instructions on how to release, let me know if you guys have questions on that.

@spboyer
Copy link
Contributor Author

spboyer commented Feb 7, 2015

@sayedihashimi great! Forgot about these pages.

@peterblazejewicz
Copy link
Member

@sayedihashimi I can't say here nothing conclusively - I still cannot compile some of project templates due to some changes in kvm/kre as in linked topic:
dotnet/aspnetcore#310
I can compile a projects that are in aspnet/home dev branch but some of ours fail to compile at the moment on my machine.

@sayedihashimi
Copy link
Member

@peterblazejewicz when I got latest I did kvm upgrade and ran through kpm restore and kpm build for all projects. For web projects I tried k kestrel and for the console app k run, they all worked except the unit test and this was because xUnit was not found. That will get fixed later when xUnit goes to nuget.org.

I haven't tried any updates from aspnet dev.

What version of mono do you have? I have 3.8.0.

@spboyer
Copy link
Contributor Author

spboyer commented Feb 7, 2015

@peterblazejewicz @sayedihashimi I bui all projects on OSX Yosemite with mono 3.8.0, and on Windows 8.1 in VS 2015 CTP 5.

Only challenge I have is Travis CI is failing but local test are passing. Need to see why, npm locally is 2.8.x, need to look at how to make sure Travis is running the same. I'm a noob there.

@sayedihashimi
Copy link
Member

When I updated kvm threw homebrew now things are hosed. @spboyer you may want to keep the setup you currently have until it's resolved.

Previously I was using mono 3.8.0 and after brew upgrade kvm and then kvm upgrade mono was updated to 3.12.0 and kvm was upgraded as well. I switched mono back to 3.8.0 with brew switch mono 3.8.0 from my previous install. After that kpm restore was still failing so I think its with the kvm brew formula or something. Not sure. I'll reply back to the issue on aspnet.

@peterblazejewicz
Copy link
Member

@sayedihashimi

mono --version
Mono JIT compiler version 3.10.0 (tarball Wed Oct 22 10:06:03 BST 2014)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
k --version
1.0.0-beta3-11030

@sayedihashimi
Copy link
Member

OK I spent some time on this and got things working here is what I found.

When I was running kvm upgrade it was pulling the latest beta3 packages from myget.org. I spent some time trying to figure out where myget.org was coming from but was unable to figure that out. Instead what I did was set the KRE_FEED env var to nuget.org and then reinstalled kvm. Here are the commands I used.

export KRE_FEED="https://www.nuget.org/api/v2"
rm -r -f ~/.kpm/packages/
kvm install 1.0.0-beta2 -p

I deleted the ~/.kpm/packages/ to remove any packages which may have come from myget or other branches. It's safe to delete that folder. It will come back when kpm restore is invoked.

Using -p updates default.alias to point to the beta2 runtime, and it will remain that until you run kvm install -p or kvm upgrade.

After that run yo aspnet to create a new project, and then kpm restore and kpm build.

@peterblazejewicz can you try it out and let me know if it works for you?

It might make sense to export KRE_FEED="https://www.nuget.org/api/v2" to the profile script so that you're using nuget.org by default.

@peterblazejewicz
Copy link
Member

@sayedihashimi busy testing

@peterblazejewicz
Copy link
Member

@sayedihashimi
Every example except of NancyApplication restore, builds and runs with the above solution.
Unfortunately the Nancy project fails to build, here is an output from terminal:
https://gist.github.com/peterblazejewicz/5909c2d36e64930170e6

Thanks for sticking with this problem

@sayedihashimi
Copy link
Member

@peterblazejewicz how about the other project types? Are they working for you? We have Nancy updates in a commit which has not been published so I'm hoping that may fix it but have not yet tested.

@peterblazejewicz
Copy link
Member

@sayedihashimi Sayed, yes, every other sample project restores, builds and runs just fine with above.
💃

@sayedihashimi
Copy link
Member

@peterblazejewicz ok, that's fine for now. We can revisit Nancy after beta3 is on nuget.org.

@peterblazejewicz
Copy link
Member

SGTM 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants