This repository was archived by the owner on Feb 13, 2019. It is now read-only.
🐳 Dockerfile support refactoring with optional SQLite support #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dockerfile will support two different options: - without SQLite package installation and without call to EF migrations - with SQLite and EF migrations implementation
The --sqlite option controls if SQLite support is added to generated Docker dotnet image - required by MVC web starter projects that use EntityFramework The --sqlite option can be used with subgenerator and is pre-set when project type if starter web (with SQLite backed EF database implementation)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional support for SQLite package added to generated Docker image - as required by web starter project with individual accounts (SQLite backed EF).
The PR introduces explicit
--sqliteoption forDockerfilesubgenerator and implicit--sqliteoption set to true when scaffolding project of typeweb(starter web with EF + SQLite).The PR introduces changes in unit tests to cover all scenarios for Dockerfile creation
For details about implementation:
#743
Thanks!
/cc
@sesispla
@OmniSharp/generator-aspnet-team-push