Support plugins configuration in omnisharp.json

[dmgonch]

Locations for OminSharp’s plugins can currently be configured only via –plugin command line argument. But when OminSharp is activated as a part of ms-vscode.csharp extension, other VSCode extensions cannot use this approach to supply their own plugins for OmniSharp. The only exception are code actions which can be configured in omnisharp.json via RoslynExtensionsOptions. The proposed changes enable OmniSharp to discover any plugin using the same technique via new Plugins section in omnisharp.json, i.e.:

"Plugins": {
    "LocationPaths": [ "path_to_plugin1.dll", "path_to_plugin2.dll" ]
}

An example of VSCode extension that provides plugins via omnisharp.json is Roslynator which does it via RoslynExtensionsOptions.

[filipw]

thanks - overall this is a good idea and a welcome addition.
I am not convinced that this is the best implementation though. I'd rather see types under OmniSharp.Options to be used in a consistent, strongly typed way rather than using the raw IConfigurationRoot to bind to them multiple times in multiple places.

This would mean that we need to refactor the code a bit to perhaps delay the decision about plugin discovery or move the options bootstrapping up.
I will have a closer look when I have some time.

[david-driscoll]

I'm with @filipw I like the idea but the solution feels wrong somehow. I'm going to have to circle back to this, this weekend after my local code camp.

[dmgonch]

Good feedback! Switched to using strongly typed object for declaring locations for plugins.

[dmgonch]

@filipw @david-driscoll Curious what you guys think of the latest changes.

[filipw]

thanks a lot - it will be reviewed carefully as soon as there is some free time.
but after #1625 we don't want to rush any changes without thoroughly testing and pulling locally.

[dmgonch]

@filipw a gentle ping since it's been few weeks. thanks

[filipw]

sorry! I will do my best to review in the coming days! 🙏

[filipw]

LGTM - thanks!

[filipw]

any thoughts? @david-driscoll @mholo65 @JoeRobich

if not IMHO this is good to merge and a very valuable feature

[bjorkstromm]

Great work. A minor nit/question about the logging in the assembly loader extension.

[JoeRobich]

LGTM

[david-driscoll]

LGTM

[filipw]

thanks!