Support for <RunAnalyzers /> and <RunAnalyzersDuringLiveAnalysis />#1739
Merged
Support for <RunAnalyzers /> and <RunAnalyzersDuringLiveAnalysis />#1739
<RunAnalyzers /> and <RunAnalyzersDuringLiveAnalysis />#1739Conversation
|
|
JoeRobich
approved these changes
Mar 25, 2020
Member
JoeRobich
left a comment
JoeRobich
left a comment
There was a problem hiding this comment.
I didn't know about these properties before this PR. =) https://docs.microsoft.com/en-us/visualstudio/code-quality/disable-code-analysis?view=vs-2019#net-framework-projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for honoring
<RunAnalyzers />and<RunAnalyzersDuringLiveAnalysis />settings in csproj files.Note that this is different than the OmniSharp specific global setting to toggle analyzers on/off (in those cases we don't decorate code check services with one that's analyzer-friendly).
Here it's project level and we can toggle this on/off in csproj and get real time response from Omnisharp (via project reload). This is on-par with feature that's already in VS and in command line builds.