LSP: fix performance of the textDocument/codeAction request#1814
Merged
david-driscoll merged 8 commits intoOmniSharp:masterfrom Aug 3, 2020
Merged
LSP: fix performance of the textDocument/codeAction request#1814david-driscoll merged 8 commits intoOmniSharp:masterfrom
david-driscoll merged 8 commits intoOmniSharp:masterfrom
Conversation
This improves performance of codeAction request on large codes base quite a bit by making the response from textDocument/codeAction to be more lightweight. This is accomplished by adding a separate command handler for "omnisharp/executeCodeAction" that actually sends the changes to client with "workspace/applyEdit".
…funcitonality is working as expected
david-driscoll
approved these changes
Aug 2, 2020
Member
david-driscoll
left a comment
david-driscoll
left a comment
There was a problem hiding this comment.
I have updated against the latest and went ahead and added in the related unit tests (stuff that wasn't available at the time this PR was created!)
Member
|
Thanks @razzmatazz |
JoeRobich
approved these changes
Aug 3, 2020
razzmatazz
pushed a commit
to razzmatazz/omnisharp-roslyn
that referenced
this pull request
May 2, 2021
This feature was introduced in LSP 3.16.0 https://microsoft.github.io/language-server-protocol/specification#codeAction_resolve and allows us to drop the hack where we were introducing a special "omnisharp/executeCodeAction" command to delay the resolution of code action changesets until user actually selets that code action: see OmniSharp#1814. Related to: - OmniSharp#2068 - OmniSharp#1814
razzmatazz
pushed a commit
to razzmatazz/omnisharp-roslyn
that referenced
this pull request
May 2, 2021
This feature was introduced in LSP 3.16.0 https://microsoft.github.io/language-server-protocol/specification#codeAction_resolve and allows us to drop the hack where we were introducing a special "omnisharp/executeCodeAction" command to delay the resolution of code action changesets until user actually selets that code action: see OmniSharp#1814. Related to: - OmniSharp#2068 - OmniSharp#1814
razzmatazz
pushed a commit
to razzmatazz/omnisharp-roslyn
that referenced
this pull request
May 8, 2021
This feature was introduced in LSP 3.16.0 https://microsoft.github.io/language-server-protocol/specification#codeAction_resolve and allows us to drop the hack where we were introducing a special "omnisharp/executeCodeAction" command to delay the resolution of code action changesets until user actually selets that code action: see OmniSharp#1814. Related to: - OmniSharp#2068 - OmniSharp#1814
razzmatazz
pushed a commit
to razzmatazz/omnisharp-roslyn
that referenced
this pull request
May 8, 2021
This feature was introduced in LSP 3.16.0 https://microsoft.github.io/language-server-protocol/specification#codeAction_resolve and allows us to drop the hack where we were introducing a special "omnisharp/executeCodeAction" command to delay the resolution of code action changesets until user actually selets that code action: see OmniSharp#1814. Related to: - OmniSharp#2068 - OmniSharp#1814
razzmatazz
pushed a commit
to razzmatazz/omnisharp-roslyn
that referenced
this pull request
May 12, 2021
This feature was introduced in LSP 3.16.0 https://microsoft.github.io/language-server-protocol/specification#codeAction_resolve and allows us to drop the hack where we were introducing a special "omnisharp/executeCodeAction" command to delay the resolution of code action changesets until user actually selets that code action: see OmniSharp#1814. Related to: - OmniSharp#2068 - OmniSharp#1814
razzmatazz
pushed a commit
to razzmatazz/omnisharp-roslyn
that referenced
this pull request
Aug 3, 2021
This feature was introduced in LSP 3.16.0 https://microsoft.github.io/language-server-protocol/specification#codeAction_resolve and allows us to drop the hack where we were introducing a special "omnisharp/executeCodeAction" command to delay the resolution of code action changesets until user actually selets that code action: see OmniSharp#1814. Related to: - OmniSharp#2068 - OmniSharp#1814
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves performance of codeAction request on large code bases
quite a bit by making the response from textDocument/codeAction to be more
lightweight. This is accomplished by adding a separate command handler for
"omnisharp/executeCodeAction" that actually sends the changes to client
with "workspace/applyEdit".