Only request dotnet info once for the solution or directory#1857
Merged
filipw merged 4 commits intoOmniSharp:masterfrom Jul 22, 2020
Merged
Only request dotnet info once for the solution or directory#1857filipw merged 4 commits intoOmniSharp:masterfrom
filipw merged 4 commits intoOmniSharp:masterfrom
Conversation
Member
|
This PR does indeed get things running in WSL for me, and it's nice and speedy too. |
Member
Author
|
@mholo65 @david-driscoll Please take a look |
bjorkstromm
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1844
Although each project could define their own global.json with differing sdks, in practice there is no need to request dotnet info for each loaded project.