Handle records in syntax highlighting#2049
Merged
filipw merged 1 commit intoOmniSharp:masterfrom Dec 27, 2020
Merged
Conversation
333fred
force-pushed
the
fix-record-highlight
branch
from
b05c01b to
6321175
Compare
Contributor
Author
|
@JoeRobich for review. |
333fred
commented
Dec 22, 2020
| [ClassificationTypeNames.VerbatimStringLiteral] = SemanticHighlightClassification.VerbatimStringLiteral, | ||
| [ClassificationTypeNames.StringEscapeCharacter] = SemanticHighlightClassification.StringEscapeCharacter, | ||
| [ClassificationTypeNames.ClassName] = SemanticHighlightClassification.ClassName, | ||
| [ClassificationTypeNames.RecordName] = SemanticHighlightClassification.ClassName, |
Contributor
Author
There was a problem hiding this comment.
The other option would be to map a separate classification for record names and have the clients deal with it. Which is fine, just need to know what to do.
Contributor
Author
There was a problem hiding this comment.
Well, the only concern is that we'll need to do something different when struct records come out, but that's a concern for next year :).
filipw
approved these changes
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2048.