use "variable" kind for parameter completion

[filipw]

We used to do it this way until the switch to CompletionService. This PR restores the old mapping of parameter to variable.

Fixes #2060
Fixes dotnet/vscode-csharp#4314

[filipw]

cc @333fred

[333fred]

Interesting. This is copied directly from roslyn, https://github.com/dotnet/roslyn/blob/master/src/Features/LanguageServer/Protocol/Extensions/ProtocolConversions.cs#L57. @dibarbet, is Roslyn intentionally using value for parameters there, or is it an oversight?

[filipw]

yes I saw this too and got confused. but then tested in VS directly and saw there that locals and parameters use same glyph. is it remapped elsewhere?

[333fred]

yes I saw this too and got confused. but then tested in VS directly and saw there that locals and parameters use same glyph. is it remapped elsewhere?

That map is only used by the LSP, so you won't see it unless you're using codespaces.

[dibarbet]

@dibarbet, is Roslyn intentionally using value for parameters there, or is it an oversight?

good question, it very well could be an oversight, or VS just uses the same icon for both, @allisonchou do you happen to remember?

[allisonchou]

good question, it very well could be an oversight, or VS just uses the same icon for both, @allisonchou do you happen to remember?

I'm not sure. 😦 It may have been an oversight. Looking at the file history, it looks like this mapping has been here since LSP was first tested out in Roslyn.

[333fred]

Filed dotnet/roslyn#50324 on Roslyn to investigate whether we're using the wrong value as well.

[filipw]

thanks!