Skip to content

changed the default RunFixAllRequest timeout to 10 seconds#2066

Merged
JoeRobich merged 1 commit intomasterfrom
feature/fixalltimeout
Jan 20, 2021
Merged

changed the default RunFixAllRequest timeout to 10 seconds#2066
JoeRobich merged 1 commit intomasterfrom
feature/fixalltimeout

Conversation

@filipw
Copy link
Copy Markdown
Member

@filipw filipw commented Jan 20, 2021

This is now equal to the go to metadata timeout which is also 10 seconds. Three seconds is too short especially for solution wide fixes.

That said, it would be good for editors to have their own setting.

@JoeRobich JoeRobich merged commit ff7bdca into master Jan 20, 2021
@filipw filipw deleted the feature/fixalltimeout branch February 13, 2021 00:05
@tverboon
Copy link
Copy Markdown

Not sure if commenting here is the right way to do this, but is there a reason not increase this timeout after 30 sec? 10 seconds is an improvement, but even 10 seconds are passing quick sometimes with a medium sized project. I know, eventually 30 seconds won't be enough at some point.

My guess is that users are more willing to wait for this FixAll operation, than go to metadata. My alternative is doing it by hand and that will take a lot longer than 30 secs 😄

@filipw
Copy link
Copy Markdown
Member Author

filipw commented Sep 1, 2022

The idea was that this is only a reasonable default, and that each editor would expose a configurable value on its own (which VS Code extension does not do at the moment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants