changed the default RunFixAllRequest timeout to 10 seconds#2066
Merged
changed the default RunFixAllRequest timeout to 10 seconds#2066
Conversation
JoeRobich
approved these changes
Jan 20, 2021
|
Not sure if commenting here is the right way to do this, but is there a reason not increase this timeout after 30 sec? 10 seconds is an improvement, but even 10 seconds are passing quick sometimes with a medium sized project. I know, eventually 30 seconds won't be enough at some point. My guess is that users are more willing to wait for this FixAll operation, than go to metadata. My alternative is doing it by hand and that will take a lot longer than 30 secs 😄 |
Member
Author
|
The idea was that this is only a reasonable default, and that each editor would expose a configurable value on its own (which VS Code extension does not do at the moment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is now equal to the go to metadata timeout which is also 10 seconds. Three seconds is too short especially for solution wide fixes.
That said, it would be good for editors to have their own setting.