Enable OmniSharp.Cake tests for .NET 6#2307
Merged
filipw merged 3 commits intoOmniSharp:masterfrom Jan 11, 2022
Merged
Conversation
Contributor
|
Looks like there are some test failures. |
Member
|
looks like some of the tests deadlocked (?) |
Member
|
This error in the failing MacOS leg looks suspicious. |
Member
Author
Hmm, we don't have Mono at all in the .NET 6 tests I assume. Cake.Bakery itself is a .NET 6 console app, but it includes a wrapper for Mono. I'll add a check if we are running Mono or .NET6 and launch the appropriate executable based on runtime. |
333fred
approved these changes
Jan 7, 2022
Member
|
I merged this, although I hope this deadlock is now really gone and not that the checks just passed 'accidentally' 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.