Update Roslyn to 4.3.0-3.22329.4#2416
Closed
JoeRobich wants to merge 6 commits intoOmniSharp:masterfrom
Closed
Conversation
filipw
approved these changes
Jun 29, 2022
…/omnisharp-roslyn into update-roslyn-4.3.0-2.22307.14
Member
|
Thanks for tackling the line normalizations, I can imagine how annoying this must 🙈 |
Member
Author
|
I think I need to scrap this and start over. I believe the problem is with the O# implementation of ILegacyGlobalOptionsWorkspaceService that I added to Roslyn. I let it take all defaults because I didn't expect a lot of things to still be using the Legacy options, however, I see where it could be inheriting Environment.NewLine as its NewLine character instead of taking the appropriate formatting option. |
Member
Author
|
Superseded by #2420 |
auto-merge was automatically disabled
July 19, 2022 23:07
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/vscode-csharp#5248