Add explicit System.Memory dependency to Hosts#2443
Merged
JoeRobich merged 7 commits intoOmniSharp:masterfrom Aug 31, 2022
Merged
Add explicit System.Memory dependency to Hosts#2443JoeRobich merged 7 commits intoOmniSharp:masterfrom
JoeRobich merged 7 commits intoOmniSharp:masterfrom
Conversation
Member
|
From the error logs it looks like this PR will also fix #2442 and OmniSharp/omnisharp-vim#803 |
Link to suspected failing change dotnet/msbuild#7642
333fred
reviewed
Aug 31, 2022
|
|
||
| <dependentAssembly> | ||
| <assemblyIdentity name="System.Memory" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" /> | ||
| <bindingRedirect oldVersion="0.0.0.0-4.0.1.2" newVersion="4.0.1.2" /> |
Contributor
There was a problem hiding this comment.
Why doesn't this version match up with the dependency version?
Member
Author
There was a problem hiding this comment.
Because the assembly version doesn't match the nuget package version.
Member
Author
There was a problem hiding this comment.
333fred
approved these changes
Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/vscode-csharp#5352
Similar to dotnet/roslyn#63545. O# needs to have the newer version of System.Memory available when running against newer releases of VS Build Tools or .NET SDKs.
Also updates SDKs to a version that would have issues loading.