Respond to vscode breaking change in 1.79.2 that triggers completion inside words#2542
Merged
JoeRobich merged 2 commits intoOmniSharp:masterfrom Jun 16, 2023
Merged
Conversation
genlu
reviewed
Jun 16, 2023
genlu
approved these changes
Jun 16, 2023
JoeRobich
approved these changes
Jun 16, 2023
Member
JoeRobich
left a comment
JoeRobich
left a comment
There was a problem hiding this comment.
Looks good. I saw Gen's change and was hoping someone would port it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/vscode-csharp#5801
VSCode made a change in completion somewhere between 1.78.2 and 1.79.2 where they now trigger completion automatically inside words. This was confirmed as an intentional change here - microsoft/vscode#185286
However, this has caused lots of bug reports on us because O# will replace the entire word (including after the cursor) if a completion is accepted, instead of just inserting the selected completion item before the cursor.
This does the same change as we did to fix this in Roslyn LSP - we limit the range to the cursor position. See dotnet/roslyn#68624
Now looks like
