-
Notifications
You must be signed in to change notification settings - Fork 11
i18n: update attach to pin tips #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe update changes the user message for the "Attach to PIN" feature across multiple language files. The message now tells users to use the latest version of the OneKey App to access this feature, instead of stating that the current version does not support it. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (6)
core/src/trezor/lvglui/i18n/locales/ja.py (1)
1017-1017
: Use consistent term "OneKeyアプリ".core/src/trezor/lvglui/i18n/locales/ru.py (1)
1017-1017
: Inconsistent wordingТермин «OneKey App» выбивается из общего стиля, чаще используется «приложение OneKey».
core/src/trezor/lvglui/i18n/locales/es.py (1)
1017-1017
: Spanish phrasing off“El la OneKey App” mezcla artículo y nombre en inglés; rompe coherencia.
core/src/trezor/lvglui/i18n/locales/zh_cn.py (1)
1017-1017
: Quotes mismatchcore/src/trezor/lvglui/i18n/locales/en.py (1)
1017-1017
: Duplicate “use” wordingcore/src/trezor/lvglui/i18n/locales/de.py (1)
1017-1017
: Redundant wording
Doppelt: „verwenden … nutzen“.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (12)
core/src/trezor/lvglui/i18n/keys.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/de.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/en.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/es.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/fr.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/it.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/ja.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/ko.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/pt_br.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/ru.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/zh_cn.py
(1 hunks)core/src/trezor/lvglui/i18n/locales/zh_hk.py
(1 hunks)
👮 Files not reviewed due to content moderation or server errors (3)
- core/src/trezor/lvglui/i18n/locales/zh_hk.py
- core/src/trezor/lvglui/i18n/locales/ko.py
- core/src/trezor/lvglui/i18n/locales/it.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Gen check
- GitHub Check: Defs check
- GitHub Check: Style check
🔇 Additional comments (3)
core/src/trezor/lvglui/i18n/locales/pt_br.py (1)
1017-1017
: Translation looks correct.The Portuguese translation properly conveys the updated message instructing users to use the latest OneKey App version.
core/src/trezor/lvglui/i18n/locales/fr.py (1)
1017-1017
: French translation is accurate.The message correctly instructs users to use the latest OneKey App version for PIN association.
core/src/trezor/lvglui/i18n/keys.py (1)
2231-2231
: Avoid repeating “use”
[ suggest_nitpick ]
Summary by CodeRabbit