Skip to content

Conversation

somebodyLi
Copy link
Contributor

@somebodyLi somebodyLi commented Sep 3, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Restored compatibility with the Tron V1 message format, ensuring successful signing, verification, and interaction with services that still rely on the older protocol. This reduces errors and improves interoperability across the Tron ecosystem.
  • Chores

    • Bumped firmware patch version to 4.16.1 to deliver these improvements.

@somebodyLi somebodyLi requested a review from a team as a code owner September 3, 2025 05:52
Copy link

coderabbitai bot commented Sep 3, 2025

Walkthrough

Removed deprecated flag from TronMessageType.V1 in proto, added V1 constant to the Python enum, and bumped firmware patch version from 0 to 1. No other logic or structure changed.

Changes

Cohort / File(s) Summary
Tron message type updates
common/protob/messages-tron.proto, core/src/trezor/enums/TronMessageType.py
Proto: TronMessageType.V1 deprecation removed (V1 = 1). Python enum: added V1 = 1; existing V2 = 2 unchanged.
Firmware version bump
core/embed/firmware/version.h
ONEKEY_VERSION_PATCH changed from 0 to 1, updating computed version string accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/tron

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@revan-zhang
Copy link
Contributor

revan-zhang commented Sep 3, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
common/protob/messages-tron.proto (3)

62-67: Spelling: "resouce"


50-50: Inconsistent "base58" vs "base 58"

Also applies to: 55-55, 74-74


59-60: Comment mismatch for call_token_value/asset_id

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge Base: Disabled due to data retention organization setting

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5838a9d and 54afe04.

📒 Files selected for processing (3)
  • common/protob/messages-tron.proto (1 hunks)
  • core/embed/firmware/version.h (1 hunks)
  • core/src/trezor/enums/TronMessageType.py (1 hunks)
👮 Files not reviewed due to content moderation or server errors (2)
  • core/src/trezor/enums/TronMessageType.py
  • core/embed/firmware/version.h
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Gen check
  • GitHub Check: Style check
  • GitHub Check: Defs check

@somebodyLi somebodyLi merged commit 2b531db into main Sep 10, 2025
9 checks passed
@somebodyLi somebodyLi deleted the fix/tron branch September 10, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants