Skip to content

Updating MainMenu.cpp C-style pointers to use C++ style pointers#165

Merged
jgfoster merged 10 commits intoOpen-Acidification:mainfrom
IDzyre:main
Jun 8, 2021
Merged

Updating MainMenu.cpp C-style pointers to use C++ style pointers#165
jgfoster merged 10 commits intoOpen-Acidification:mainfrom
IDzyre:main

Conversation

@IDzyre
Copy link
Copy Markdown
Contributor

@IDzyre IDzyre commented May 26, 2021

I changed the C-style pointers in MainMenu.cpp to C++ style pointers.

@IDzyre IDzyre marked this pull request as ready for review May 26, 2021 19:42
prestoncarman
prestoncarman previously approved these changes May 26, 2021
Copy link
Copy Markdown
Member

@prestoncarman prestoncarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prestoncarman
Copy link
Copy Markdown
Member

Looks like you need to add a third parenthesis at the end of each line.

@prestoncarman prestoncarman dismissed their stale review May 26, 2021 21:36

Failed to compile.

@prestoncarman prestoncarman changed the title Cameron -- C-style pointers to C++ style pointers Updating MainMenu.cpp C-style pointers to use C++ style pointers May 26, 2021
@jgfoster
Copy link
Copy Markdown
Member

jgfoster commented Jun 2, 2021

@IDzyre, Will you be able to make the required edits to get the tests to pass? Let me know if you need help.

@jgfoster jgfoster mentioned this pull request Jun 3, 2021
@jgfoster jgfoster merged commit 39e710c into Open-Acidification:main Jun 8, 2021
@prestoncarman
Copy link
Copy Markdown
Member

@all-contributors please add @IDzyre for code

@allcontributors
Copy link
Copy Markdown
Contributor

@prestoncarman

I've put up a pull request to add @IDzyre! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants