Trigger a reset if the pH goes below 7.0#229
Merged
jgfoster merged 5 commits intoOpen-Acidification:mainfrom Jul 20, 2021
Merged
Trigger a reset if the pH goes below 7.0#229jgfoster merged 5 commits intoOpen-Acidification:mainfrom
jgfoster merged 5 commits intoOpen-Acidification:mainfrom
Conversation
added 3 commits
July 19, 2021 17:38
prestoncarman
approved these changes
Jul 20, 2021
| // convert the string to a floating point number so it can be evaluated by the Arduino | ||
| value = string.toFloat(); | ||
| // we have seen situations where the CO2 bubbler stays on and drives the pH down | ||
| if (value < 7.0) { // hang so as to trigger the watchdog timer reset |
Member
There was a problem hiding this comment.
While this could be hard coded, this seems like a threshold that should be user defined. Maybe we open an issue for customization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So bubbler isn't on continually.