Skip to content

Support basic HTTP get file request#254

Merged
jgfoster merged 17 commits intoOpen-Acidification:mainfrom
jgfoster:http
Aug 30, 2021
Merged

Support basic HTTP get file request#254
jgfoster merged 17 commits intoOpen-Acidification:mainfrom
jgfoster:http

Conversation

@jgfoster
Copy link
Copy Markdown
Member

This supports /echo?key="value" requests and /path requests. Large files take a long time to transfer. Following are some measurements of time with different buffer sizes:

Buffer size: 128
file "/20210827.csv" has a size of 5713467
write = 5713467; freeMemory = 4640
timeInRead = 27661; timeInWrite = 79832; timeInFlush = 43

Buffer size: 2048
file "/20210827.csv" has a size of 5858009
write = 5858009; freeMemory = 2720
timeInRead = 11681; timeInWrite = 74739; timeInFlush = 3

Buffer size: 1024
file "/20210827.csv" has a size of 5878029
write = 5878029; freeMemory = 3744
timeInRead = 15108; timeInWrite = 72649; timeInFlush = 3

The entire process is blocking so there is a risk of leaving the bubbler on for minutes. Thus, the reading files feature should be considered a basic alternative to taking the device apart to read files.

@jgfoster jgfoster requested a review from prestoncarman August 28, 2021 02:27
Copy link
Copy Markdown
Member

@prestoncarman prestoncarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgfoster jgfoster merged commit adcdb97 into Open-Acidification:main Aug 30, 2021
@jgfoster jgfoster deleted the http branch August 30, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants