Support basic HTTP get file request#254
Merged
jgfoster merged 17 commits intoOpen-Acidification:mainfrom Aug 30, 2021
Merged
Conversation
added 15 commits
August 24, 2021 21:43
…on line) * Print SD card directory on startup * Add all serial output to the SD card as date.log
* Add some commented-out debugging logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supports
/echo?key="value"requests and/pathrequests. Large files take a long time to transfer. Following are some measurements of time with different buffer sizes:The entire process is blocking so there is a risk of leaving the bubbler on for minutes. Thus, the reading files feature should be considered a basic alternative to taking the device apart to read files.