Skip to content

Add ramp function for pH#266

Merged
jgfoster merged 16 commits intoOpen-Acidification:mainfrom
eucalvo:addRamp
Nov 11, 2021
Merged

Add ramp function for pH#266
jgfoster merged 16 commits intoOpen-Acidification:mainfrom
eucalvo:addRamp

Conversation

@eucalvo
Copy link
Copy Markdown
Collaborator

@eucalvo eucalvo commented Nov 4, 2021

No description provided.

Copy link
Copy Markdown
Member

@jgfoster jgfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss the change in size and see how that affects things. We may need to add something to the automated test to show us the new value. Otherwise, see the notes in the files...

Comment thread src/Devices/PHControl.cpp
Comment thread src/Devices/PHControl.cpp
Comment thread src/Devices/PHControl.cpp Outdated
Comment thread src/Devices/PHControl.cpp
Comment thread test/PHControlTest.cpp
@eucalvo eucalvo requested a review from jgfoster November 10, 2021 20:06
@jgfoster jgfoster merged commit f018e4a into Open-Acidification:main Nov 11, 2021
@eucalvo eucalvo deleted the addRamp branch March 3, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants