Sine wave pH#269
Conversation
prestoncarman
left a comment
prestoncarman
left a comment
There was a problem hiding this comment.
The main question is how to deal with naming pH variables and files. I think we need to be more consistent. We seem to use "pH", "PH", and "Ph". I can see arguments for all of these, but in most cases I think that "Ph" is probably the correct answer.
Thought?
| float EEPROM_TC::getRampStartingTemp() { | ||
| return eepromReadFloat(RAMP_STARTING_TEMP_ADDRESS); | ||
| } | ||
| uint16_t EEPROM_TC::getPHSetType() { |
There was a problem hiding this comment.
"Ph" or "PH"? Lets be consistent and make it always "Ph" in the function names.
| void EEPROM_TC::setRampStartingTemp(float value) { | ||
| eepromWriteFloat(RAMP_STARTING_TEMP_ADDRESS, value); | ||
| } | ||
| void EEPROM_TC::setPHSetType(uint16_t value) { |
There was a problem hiding this comment.
"Ph" or "PH"? Lets be consistent and make it always "Ph" in the function names.
| float getPHInterval(); // not used | ||
| float getPHSeriesPointer(); // not used | ||
| float getPHSeriesSize(); // not used | ||
| float getPHDelay(); // not used |
There was a problem hiding this comment.
"Ph" or "PH"? Lets be consistent and make it always "Ph" in the function names. Update for the whole file.
| enterKey('D'); | ||
| } | ||
|
|
||
| // 2 goes up in the menu |
There was a problem hiding this comment.
I think this comment would be nice to have as a multiline comment associated with the function.
/**
* 2 goes up in the menu
* ...
*/
unittest(MainMenu) {This should help it to show up with function documentation.
|
The chemists and biologists use "pH" as the proper designation, but that doesn't fit very well with camelCase. So, consistency is good and Ph fits so I'd be inclined to go with that... |
3 participants
No description provided.