EthernetServer API#284
Merged
pianistrevor merged 27 commits intoOpen-Acidification:mainfrom Feb 23, 2022
Merged
Conversation
Collaborator
pianistrevor
commented
Feb 16, 2022
pianistrevor
commented
- Handle GET and POST requests for the display and keypresses
- Return a JSON file with all current values
- Add test coverage for each
added 18 commits
January 12, 2022 01:42
Member
|
It looks like the JSON Builder is expecting the old version. We should look at a way to simplify updating the version without changing it in many places! |
Collaborator
Author
|
Yes, I hard coded it into the test. We can either change it there or do more complex string interpolation with the static version number |
prestoncarman
requested changes
Feb 18, 2022
Member
prestoncarman
left a comment
prestoncarman
left a comment
There was a problem hiding this comment.
Note the I only commented on one file, but it affects most of them.
| client.stop(); | ||
| server->loop(); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Add test for current endpoint.
Collaborator
Author
There was a problem hiding this comment.
Were you referring to the unit test for display, or did you have something else in mind?
Collaborator
Author
There was a problem hiding this comment.
Test for current values added to EthernetServerTest.cpp
| }; | ||
| } | ||
|
|
||
| int SeeDeviceAddress::writeToBuffer(char* buffer, int size, int line) { |
Member
There was a problem hiding this comment.
- Refactor to use a ENUM to identify the type of display instead of the size of the buffer.
- Refactor to identify the information displayed to use more appropriate term instead of "line".
prestoncarman
approved these changes
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.