Skip to content

Fix multiple NumCollectorStateBugs#288

Merged
jgfoster merged 10 commits intoOpen-Acidification:mainfrom
pianistrevor:FixNumCollectorState
Mar 2, 2022
Merged

Fix multiple NumCollectorStateBugs#288
jgfoster merged 10 commits intoOpen-Acidification:mainfrom
pianistrevor:FixNumCollectorState

Conversation

@pianistrevor
Copy link
Copy Markdown
Collaborator

@pianistrevor pianistrevor commented Feb 25, 2022

  • Use dtostrf() for printing entry with appropriate precision, rather than the original method of formatting a format string
  • Fix bug where clearing value did not reset the factor of precision
  • Add test coverage for clear to catch this

This fixes #273.

@pianistrevor
Copy link
Copy Markdown
Collaborator Author

The extra commits were the result of incorrect upstream merges; these will be squashed here and I've corrected the problem in main on my fork.

Copy link
Copy Markdown
Member

@jgfoster jgfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've asked @prestoncarman to approve as well.

Copy link
Copy Markdown
Member

@prestoncarman prestoncarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgfoster jgfoster merged commit f21478a into Open-Acidification:main Mar 2, 2022
@pianistrevor pianistrevor deleted the FixNumCollectorState branch March 2, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question mark on display when entering floating-point numbers

3 participants