Skip to content

Remove pH failsafe#290

Merged
jgfoster merged 9 commits intoOpen-Acidification:mainfrom
pianistrevor:RemovePHFailsafe
Mar 2, 2022
Merged

Remove pH failsafe#290
jgfoster merged 9 commits intoOpen-Acidification:mainfrom
pianistrevor:RemovePHFailsafe

Conversation

@pianistrevor
Copy link
Copy Markdown
Collaborator

Fixes #231 per request of @jgfoster

@pianistrevor
Copy link
Copy Markdown
Collaborator Author

The extra commits were the result of incorrect upstream merges; these will be squashed here and I've corrected the problem in main on my fork.

Copy link
Copy Markdown
Member

@jgfoster jgfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've asked @prestoncarman to approve as well.

Copy link
Copy Markdown
Member

@prestoncarman prestoncarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@jgfoster jgfoster merged commit 87b8b78 into Open-Acidification:main Mar 2, 2022
@pianistrevor pianistrevor deleted the RemovePHFailsafe branch March 2, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customize (or eliminate) pH failsafe

3 participants