Add menu for clearing temperature calibration#296
Merged
jgfoster merged 11 commits intoOpen-Acidification:mainfrom Mar 7, 2022
Merged
Add menu for clearing temperature calibration#296jgfoster merged 11 commits intoOpen-Acidification:mainfrom
jgfoster merged 11 commits intoOpen-Acidification:mainfrom
Conversation
Update main 2021-01-17
jgfoster
approved these changes
Mar 6, 2022
Member
jgfoster
left a comment
jgfoster
left a comment
There was a problem hiding this comment.
LGTM. Let's ask @prestoncarman for a review as well...
| if (correction != 0) { | ||
| correction = 0.0; | ||
| EEPROM_TC::instance()->setCorrectedTemp(correction); | ||
| serial(F("Set temperature correction to %i.%02i"), (int)correction, (int)(correction * 100 + 0.5) % 100); |
Member
There was a problem hiding this comment.
You could just say that the new correction is "0.0", but this is fine as well.
Collaborator
Author
There was a problem hiding this comment.
I like this because we would catch it if it’s bugged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #224