-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add bearer capability per specific client #21495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Can you please take a look? @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg |
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
This is an interesting approach, but in our case the token is almost always unique. For example a BFF API takes a user token of our customers and fans-out requests to downstream services. One of these downstream APIs needs this token passed on to them to do a secure operation. So basically the token is fairly unique across requests. |
@wing328 Thanks for the headsup. I think I fixed the emails now and regenerated the samples. Can you please help target the correct release branch? |
The need for this change is that we need to be able to set the bearer Token per request (for Java native library option), we would like to reuse ApiClient (because recreating it is expensive), but bearer token needs to change. We can achieve this by creating a new api class, but reusing the ApiClient.
For example:
Related issue: #21487
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)