Skip to content

Add recording smoke test #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
abrichr opened this issue Jun 18, 2024 · 8 comments · May be fixed by #803
Open

Add recording smoke test #775

abrichr opened this issue Jun 18, 2024 · 8 comments · May be fixed by #803
Labels
💎 Bounty enhancement New feature or request

Comments

@abrichr
Copy link
Member

abrichr commented Jun 18, 2024 •
edited
Loading

Feature request

We would like to add an automated test that:

  • calls openadapt.record
  • waits for the recording.started signal to be emitted (fails after e.g. 30s if no such signal is emitted)
  • stops the recording by emitting the stop sequence on the keyboard (re-use openadapt.playback)
  • asserts something about the state of the database (e.g. that the recording has been created) and filesystem (the video and performance plots have been created)

Motivation

Avoid regressions like in:
@abrichr abrichr added the enhancement New feature or request label Jun 18, 2024
@abrichr
Copy link
Member Author

abrichr commented Jun 18, 2024

/bounty $100

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jun 18, 2024 •
edited
Loading

💎 $100 bounty • OpenAdaptAI

Steps to solve:

  1. Start working: Comment /attempt #775 with your implementation plan
  2. Submit work: Create a pull request including /claim #775 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to OpenAdaptAI/OpenAdapt!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @onyedikachi-david Jun 22, 2024, 8:59:18 AM #803
🟢 @vishwamartur Jan 20, 2025, 3:47:23 AM #938

@onyedikachi-david
Copy link

onyedikachi-david commented Jun 22, 2024 •
edited by algora-pbc bot
Loading

/attempt #775

Algora profile Completed bounties Tech Active attempts Options
@onyedikachi-david 2 bounties from 1 project
JavaScript, Shell
﹟764
 Cancel attempt

@unworld11
Copy link

@abrichr can i get assigned?

@abrichr
Copy link
Member Author

abrichr commented Jun 24, 2024

@unworld11 feel free to submit an attempt, we will merge whoever submits working code that meets the required standard first.

@onyedikachi-david onyedikachi-david linked a pull request Jun 25, 2024 that will close this issue
Open
7 tasks
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jun 25, 2024 •
edited
Loading

💡 @onyedikachi-david submitted a pull request that claims the bounty. You can visit your bounty board to reward.

vishwamartur added a commit to vishwamartur/OpenAdapt that referenced this issue Jan 20, 2025
@vishwamartur
Add recording smoke test
dc2e452 
Related to OpenAdaptAI#775

Add a recording smoke test to ensure the recording functionality works as expected.

* **New Test File**: Add `tests/openadapt/test_record.py`.
* **Setup and Teardown**: Use `pytest` fixtures to set up and tear down the test environment.
* **Recording Test**: 
  - Call `openadapt.record` and wait for the `recording.started` signal.
  - Stop the recording by emitting the stop sequence.
  - Assert the state of the database to ensure the recording is created.
  - Assert the state of the filesystem to ensure the video and performance plots are created.
@vishwamartur vishwamartur mentioned this issue Jan 20, 2025
Open
@vishwamartur
Copy link

vishwamartur commented Jan 20, 2025 •
edited by algora-pbc bot
Loading

/attempt #775

Algora profile Completed bounties Tech Active attempts Options
@vishwamartur 1 bounty from 1 project
C, BitBake,
TypeScript & more
Cancel attempt

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jan 20, 2025

💡 @vishwamartur submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(tests): Add automated test for recording functionality onyedikachi-david/OpenAdapt
4 participants
@abrichr @onyedikachi-david @vishwamartur @unworld11