Skip to content

[BugFix] Fix yFinance Intraday "end_date" Filter #7059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

[BugFix] Fix yFinance Intraday "end_date" Filter #7059

merged 1 commit into from
Mar 12, 2025

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • End date not being captured properly, need to advance the end_date when data is intraday.

  2. What?:

    • Fixes in helper yf.down_download

  3. Impact:

    • More better

  4. Testing Done:

    • Before:
      Screenshot 2025-03-11 at 9 45 31 PM

    • After:
      Screenshot 2025-03-11 at 9 39 08 PM

@deeleeramone deeleeramone added bug Bugs and bug fixes platform OpenBB Platform v4 PRs for v4 labels Mar 12, 2025
@deeleeramone deeleeramone requested a review from piiq March 12, 2025 05:39
@piiq piiq added this pull request to the merge queue Mar 12, 2025
Merged via the queue into develop with commit e1f85e5 Mar 12, 2025
12 checks passed
@piiq piiq deleted the bugfix/yfinance-intraday branch March 29, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piiq piiq piiq approved these changes

Assignees
No one assigned
Labels
bug Bugs and bug fixes platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @piiq