forked from buildroot/buildroot
-
Notifications
You must be signed in to change notification settings - Fork 50
od: od-update: Add device selection menu #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kukunin
wants to merge
5
commits into
OpenDingux:opendingux
Choose a base branch
from
Kukunin:devicemenu
base: opendingux
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It keeps a list of supported devices and their details. It tries to detect the current device Signed-off-by: Sergiy Kukunin <[email protected]>
6fab6f8
to
4976489
Compare
Device can be forced by FORCE_DEVICE env variable Signed-off-by: Sergiy Kukunin <[email protected]>
Signed-off-by: Sergiy Kukunin <[email protected]>
zear
reviewed
May 16, 2021
DEVICETREE=$1/$DEVICE_DEVICETREE.dtb | ||
|
||
if [ ! -r "$BOOTLD" ]; then | ||
echo "Bootloader $DEVICE_BOOTLOADER does not exists" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/does not exists/does not exist
zear
reviewed
May 16, 2021
|
||
[ ! -r $DEVICETREE ] && DEVICETREE=/sys/firmware/fdt | ||
if [ ! -r "$DEVICETREE" ]; then | ||
echo "Device tree $DEVICE_DEVICETREE does not exists" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device detection is unreliable and often gives inaccurate results that can lead to bricks. This PR adds one step to confirm the detected device + to select the current device manually.
Signed-off-by: Sergiy Kukunin [email protected]