add optional config parameter to specify an optional MQTT topic prefix#2553
Merged
sfeilmeier merged 6 commits intoMar 31, 2024
Merged
Conversation
|
|
Collaborator
|
Maybe we should wait until the errors of reconnecting are resolved ? see here |
sfeilmeier
approved these changes
Mar 31, 2024
sfeilmeier
left a comment
sfeilmeier
left a comment
Contributor
There was a problem hiding this comment.
I hope it's ok, that I silently updated the PR:
- rename new setting to
topicPrefixwith default value - refactor to unit-testable
createTopicPrefixmethod - add JUnit test
|
|
Sn0w3y
added a commit
to Sn0w3y/openems
that referenced
this pull request
Apr 8, 2024
* UI: fix & update translations (OpenEMS#2595) * Fix Emergency-Slider Translation * Fix EMERGENCY_RESERVE Case Match * Gitpod: add names+descriptions to ports (OpenEMS#2600) * UI: add eslint:recommended and plugin:@typescript-eslint/recommended (OpenEMS#2577) * add "eslint:recommended", "plugin:@typescript-eslint/recommended" to eslintrc * `eslint --fix src/` * Push version to 2024.4.0 * Start development of version 2024.5.0-SNAPSHOT * MQTT API Controller: add optional config parameter to specify a topic prefix (OpenEMS#2553) Co-authored-by: Stefan Feilmeier <stefan.feilmeier@fenecon.de> * Bump com.squareup.retrofit2:retrofit from 2.10.0 to 2.11.0 in /cnf (OpenEMS#2606) * Bump com.squareup.retrofit2:converter-gson from 2.10.0 to 2.11.0 in /cnf Bumps [com.squareup.retrofit2:converter-gson](https://github.com/square/retrofit) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/square/retrofit/releases) - [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md) - [Commits](square/retrofit@2.10.0...2.11.0) --- updated-dependencies: - dependency-name: com.squareup.retrofit2:converter-gson dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump com.squareup.retrofit2:adapter-rxjava3 in /cnf Bumps [com.squareup.retrofit2:adapter-rxjava3](https://github.com/square/retrofit) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/square/retrofit/releases) - [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md) - [Commits](square/retrofit@2.10.0...2.11.0) --- updated-dependencies: - dependency-name: com.squareup.retrofit2:adapter-rxjava3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump com.squareup.retrofit2:converter-scalars in /cnf Bumps [com.squareup.retrofit2:converter-scalars](https://github.com/square/retrofit) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/square/retrofit/releases) - [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md) - [Commits](square/retrofit@2.10.0...2.11.0) --- updated-dependencies: - dependency-name: com.squareup.retrofit2:converter-scalars dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump com.squareup.retrofit2:retrofit from 2.10.0 to 2.11.0 in /cnf Bumps [com.squareup.retrofit2:retrofit](https://github.com/square/retrofit) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/square/retrofit/releases) - [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md) - [Commits](square/retrofit@2.10.0...2.11.0) --- updated-dependencies: - dependency-name: com.squareup.retrofit2:retrofit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update bnd --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stefan Feilmeier <stefan.feilmeier@fenecon.de> * UI: Fix CSS in footer (OpenEMS#2594) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Stefan Feilmeier <stefan.feilmeier@fenecon.de> Co-authored-by: Hiromasa Ihara <iharahiromasa@gmail.com> Co-authored-by: samuelBloch <125453026+samuelBloch@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fanass-dev
pushed a commit
to fanass-dev/openems
that referenced
this pull request
May 6, 2024
… prefix (OpenEMS#2553) Co-authored-by: Stefan Feilmeier <stefan.feilmeier@fenecon.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need an prefix to the default MQTT topic, so an optional config parameter has been added to achive this. If the optional prefix is set, OpenEMS Edge data is published to the MQTT broker under this topic: <optional_prefix>/edge/<edge_id>/...