prepare for release 1.0.0 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wanjunlei <[email protected]>
benjaminhuo
reviewed
Feb 20, 2023
| ```xml | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>dev.openfunction.functions</groupId> |
There was a problem hiding this comment.
Can we use io.github.openfunction as group id?
https://www.cnblogs.com/flydean/p/14635788.html
There was a problem hiding this comment.
If we use the io.github.openfunction as the group id, everything will be done again, including codes, samples, and publishing.
Using io.github.openfunction instead of dev.openfunction does not provide a noticeable benefit.
There was a problem hiding this comment.
ok, openfunction.dev is also our domain name.
That's also ok
benjaminhuo
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.