-
Notifications
You must be signed in to change notification settings - Fork 6
feat: initialize openfunction knative and async runtime #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big kudos to this PR, just some comments for some corner cases
In TS, a required param cannot be placed after an optional param. |
If the output is not set, where is the data sent to? |
Will broadcast to all declared outputs In current impl. |
The broadcast could be a different method, the send just sends the output to one destination like go implementation maybe? |
As we discussed in wechat group, let's move on to roll out 0.4.0 first, then will upgrade the function interfaces to better comply with the Function Framework overall guidelines. :) |
|
This big initial PR is an important upgrade to current GCP Node.js Function Framework with following task accomplished: