Skip to content

refactor: polish http error response #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2022

Conversation

webup
Copy link
Collaborator

@webup webup commented May 27, 2022

Resolves #42

@auto-assign auto-assign bot requested a review from benjaminhuo May 27, 2022 10:33
@webup webup added the type: maintenance Minor enhancement or refactory label May 27, 2022
@mergeable
Copy link

mergeable bot commented May 27, 2022

Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

@webup
Copy link
Collaborator Author

webup commented May 27, 2022

@benjaminhuo Double confirmed existing logics, current implementation has covered error header part, though we do forget to switch the header key from google's to ours and that's been fixed in this pr.

And since we already have ctx.res and ctx.req in user function to handle response (and they are simple enough), so we are not going to provide further helper function to context object.

@benjaminhuo benjaminhuo merged commit cc9ed42 into master May 27, 2022
@webup webup deleted the feature/async-error-ouput branch May 27, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance Minor enhancement or refactory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle async function output and return error in knative runtime
2 participants