Skip to content

rector: ChangeSwitchToMatchRector #4835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 7, 2025
Merged

rector: ChangeSwitchToMatchRector #4835

merged 10 commits into from
Jul 7, 2025

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel added PHP 8 Related to PHP8 chore labels Jun 20, 2025
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports Component: Checkout Relates to Mage_Checkout Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: lib/Mage Relates to lib/Mage Component: Adminhtml Relates to Mage_Adminhtml Component: CatalogRule Relates to Mage_CatalogRule Component: SalesRule Relates to Mage_SalesRule Component: Rule Relates to Mage_Rule Component: Payment Relates to Mage_Payment Component: Api2 Relates to Mage_Api2 Component: Log Relates to Mage_Log Component: ImportExport Relates to Mage_ImportExport shell Relates to shell scripts Component: Centinel Relates to Mage_Centinel Component: Uploader Relates to Mage_Uploader Component: Paygate Relates to Mage_Paygate Component: lib/* Relates to lib/* errors Relates to error pages rector labels Jun 20, 2025
@sreichel sreichel added this to the 20.15.0 milestone Jun 20, 2025
addison74
addison74 previously approved these changes Jun 28, 2025
View reviewed changes
Hanmac
Hanmac reviewed Jul 2, 2025
View reviewed changes
@kiatng
Copy link
Contributor

kiatng commented Jul 3, 2025 •
edited
Loading

match() was introduced in PHP 8.0.0. Are we dropping support for PHP7.4?

There is currently no polyfill package that can provide the match() expression from PHP 8.0 for earlier PHP versions. 

@sreichel
Copy link
Contributor Author

sreichel commented Jul 3, 2025

Are we dropping support for PHP7.4?

We dropped 7.4 support with 20,14.0 release. (#4124) ;)

@kiatng kiatng mentioned this pull request Jul 3, 2025
Merged
Hanmac
Hanmac previously approved these changes Jul 5, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube Cloud

@sreichel sreichel merged commit 0ed04dd into OpenMage:main Jul 7, 2025
22 checks passed
@sreichel sreichel deleted the rector/php80/ChangeSwitchToMatchRector branch July 7, 2025 00:43
hirale pushed a commit to hirale/magento-lts that referenced this pull request Jul 11, 2025
@sreichel @hirale
rector: ChangeSwitchToMatchRector (OpenMage#4835)
4febb3e 
* rector: `ChangeSwitchToMatchRector`

* sonar

* sonar

* phpstan

* simpler

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hanmac Hanmac Hanmac approved these changes

@addison74 addison74 addison74 left review comments

@colinmollenhour colinmollenhour Awaiting requested review from colinmollenhour

Assignees
No one assigned
Labels
chore Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: CatalogRule Relates to Mage_CatalogRule Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: lib/Mage Relates to lib/Mage Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Log Relates to Mage_Log Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Uploader Relates to Mage_Uploader Component: Usa Relates to Mage_Usa errors Relates to error pages PHP 8 Related to PHP8 phpstan rector shell Relates to shell scripts
Projects
None yet
Milestone
20.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @kiatng @Hanmac @addison74