Skip to content

rector: ClassOnThisVariableObjectRector & ClassOnObjectRector #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2025
Merged

rector: ClassOnThisVariableObjectRector & ClassOnObjectRector #4878

merged 4 commits into from
Jul 10, 2025

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jul 7, 2025

@sreichel sreichel added this to the 20.15.0 milestone Jul 7, 2025
@sreichel sreichel added PHP 8 Related to PHP8 chore labels Jul 7, 2025
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Eav Relates to Mage_Eav Component: Index Relates to Mage_Index Component: Api2 Relates to Mage_Api2 Component: Dataflow Relates to Mage_Dataflow Component: Uploader Relates to Mage_Uploader Component: lib/* Relates to lib/* phpunit rector labels Jul 7, 2025
kiatng
kiatng previously approved these changes Jul 8, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sreichel sreichel merged commit 034f2ae into OpenMage:main Jul 10, 2025
22 checks passed
@sreichel sreichel deleted the rector/php80/ClassOnObjectRector branch July 10, 2025 23:53
hirale pushed a commit to hirale/magento-lts that referenced this pull request Jul 11, 2025
@sreichel @hirale
rector: ClassOnThisVariableObjectRector & ClassOnObjectRector (Op…
c97c97a 
…enMage#4878)

* rector: `ClassOnThisVariableObjectRector` & `ClassOnObjectRector`

- see https://getrector.com/rule-detail/class-on-this-variable-object-rector
- see https://getrector.com/rule-detail/class-on-object-rector

* fix

* sprintf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng left review comments

Assignees
No one assigned
Labels
chore Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Component: Dataflow Relates to Mage_Dataflow Component: Eav Relates to Mage_Eav Component: Index Relates to Mage_Index Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: Uploader Relates to Mage_Uploader PHP 8 Related to PHP8 phpunit rector
Projects
None yet
Milestone
20.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sreichel @kiatng