-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Xianyi's patch for segfaults on kernel 2.6.32 and add documentation accordingly. #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
From ac40907baa90a0acc78139762ffa3c6f09274236 Mon Sep 17 00:00:00 2001 | ||
From: =?UTF-8?q?Alexander=20Ebersp=C3=A4cher?= <[email protected]> | ||
Date: Wed, 2 May 2012 11:22:52 +0200 | ||
Subject: [PATCH] Fix segfaults with kernel 2.6.32. This comes at the price of many compiler warnings. | ||
|
||
--- | ||
common_linux.h | 4 ++-- | ||
1 files changed, 2 insertions(+), 2 deletions(-) | ||
|
||
diff --git a/common_linux.h b/common_linux.h | ||
index b0381d9..40a94cb 100644 | ||
--- a/common_linux.h | ||
+++ b/common_linux.h | ||
@@ -76,8 +76,8 @@ static inline int my_mbind(void *addr, unsigned long len, int mode, | ||
#endif | ||
#else | ||
//Fixed randomly SEGFAULT when nodemask==NULL with above Linux 2.6.34 | ||
-// unsigned long null_nodemask=0; | ||
- return syscall(SYS_mbind, addr, len, mode, nodemask, maxnode, flags); | ||
+ unsigned long null_nodemask=0; | ||
+ return syscall(SYS_mbind, addr, len, mode, &nodemask, maxnode, flags); | ||
#endif | ||
} | ||
|
||
-- | ||
1.7.1 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should perhaps be modified, now that the warnings are gone.